Add tootctl domains purge options to select subdomains and keep domain blocks
#22063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rge-domain-blocks is passed
ClearlyClaire
force-pushed
the
features/domain-tootctl
branch
from
28ac149
to
e659120
Compare
connorshea
reviewed
Dec 5, 2022
connorshea
approved these changes
Dec 5, 2022
15 tasks
Gargron
approved these changes
Jan 18, 2023
btrd
pushed a commit
to btrd/mastodon
that referenced
this pull request
Feb 22, 2023
…ain blocks (mastodon#22063) * Add --include-subdomains option to tootctl domains purge * Add support for '*.' subdomain wildcard patterns in `tootctl domains purge` * Fix custom emojis deletion not following subdomain and URI options * Change `tootctl domains purge` to not purge domain blocks unless --purge-domain-blocks is passed * Refactor `tootctl domains purge` * Add feedback on deleted domain blocks
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21984
--include-subdomainsoption to match both passed domains and their subdomains*.subdomain wildcard pattern regardless of--include-subdomainsas people will somewhat frequently use ittootctl domains purgeto not remove domain blocks by default, and add a--purge-domain-blocksoption to recover that behavior: in most cases, if a domain block exists, admins do not actually want to remove it.