Fix checkmark symbol for sensitive media in compose form #22795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidp
changed the title
xirclebox
approved these changes
Dec 27, 2022
|
Love to see something for our colourblind brothers and sisters. |
ClearlyClaire
approved these changes
Jan 2, 2023
|
@ClearlyClaire Good point! I took the liberty of filing a separate issue about the poll options here: #22908 |
|
We could render the SVG in the component, right? Should we really stuff it in the background property in CSS? |
|
Currently, yes, but I think if we go the #22949 route, the background property is the easiest way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #20721, where the checkbox for "Mark media as sensitive" in the compose form is not easy to distinguish between checked an unchecked states.
Before:
After: