Change email address input to be read-only for logged-in users when requesting a new confirmation e-mail #23247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…questing a new confirmation e-mail Fixes mastodon#23093
Gargron
approved these changes
Jan 24, 2023
btrd
pushed a commit
to btrd/mastodon
that referenced
this pull request
Feb 22, 2023
…questing a new confirmation e-mail (mastodon#23247) Fixes mastodon#23093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23093
If a user fails to receive their confirmation e-mail, they can request a new one through
/auth/confirmation/new. In case they are logged in, which is the most likely, this will be pre-filled with their initial e-mail address. If they change the e-mail address, they would likely expect the e-mail to be sent to the new address instead, but this is not what this controller does: it sends an e-mail to that address if it corresponds to an existing user. When the user is not logged in, this is explained in a notice, but when the user is logged in, it redirects to/auth/setup, which has a different notice.To reduce the confusion, this PR makes the input read-only and adds a hint in this case, instructing to go to Account settings to change the e-mail address:
