fix(web-push-notifications): fix favourite push notifications

[elizabeth-dev]

Fix a bug where clicking in a favourite push notification would result in a 404 (not found) error, since we were redirecting the user to the wrong URL (we were redirecting to /@<user who favourited>/<favourited status id>, when it should be /@<favourited status author>/<favourited status id>)

[elizabeth-dev]

I could have nested another ternary on line 93, but it felt a bit too much, and I saw the overwriting approach was already being used below, at line 103.

[ClearlyClaire]

Looks good to me, although I think a more generic fix wouldn't be to special-case favourite, but simply use notification.status.account.acct whenever notification.status exists.

[elizabeth-dev]

@ClearlyClaire I thought about that, but in the case of boosts, notification.status exists and we still redirect to /@<user who favourited>/<favourited status id> (for some reason). And it works, so I'm not sure about changing that existing behavior.

[ClearlyClaire]

@ClearlyClaire I thought about that, but in the case of boosts, notification.status exists and we still redirect to /@<user who favourited>/<favourited status id> (for some reason). And it works, so I'm not sure about changing that existing behavior.

Are you sure about that? I can actually experience the issue for both favourites and reblogs.

[elizabeth-dev]

@ClearlyClaire You do? I never had any issue with boost notifications, and I did test that behavior when writing this PR

Example (look at the URL vs the user in the post): https://tech.lgbt/@E_net4@hachyderm.io/109768855342795754

Maybe it's something specific to some instances?

Tbh for me it makes a lot more sense the way you suggested, since having the user who boosted in the URL does nothing at first glance. So, if you are okay with changing that, I'll be happy to update the PR.

[ClearlyClaire]

@ClearlyClaire You do? I never had any issue with boost notifications, and I did test that behavior when writing this PR

Example (look at the URL vs the user in the post): https://tech.lgbt/@E_net4@hachyderm.io/109768855342795754

Maybe it's something specific to some instances?

Actually, this seems like a weird edge case with remote VS local users. I'll look into it but it's not directly related to the issue at hand.

Tbh for me it makes a lot more sense the way you suggested, since having the user who boosted in the URL does nothing at first glance. So, if you are okay with changing that, I'll be happy to update the PR.

Sure!

[elizabeth-dev]

@ClearlyClaire I see, you're right. I'll update the PR later this morning.

stale

[elizabeth-dev]

@ClearlyClaire Hi, sorry for the delay, I've been busier than I expected. I updated the PR.

I could have brought back the ternary that was there before, but it felt less cluttered this way.