Apply Rubocop formatting rules #23301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
nschonni
force-pushed
the
rubocop-formatting
branch
from
79d53d9
to
96f0145
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
nschonni
force-pushed
the
rubocop-formatting
branch
from
96f0145
to
c5a1955
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
nschonni
force-pushed
the
rubocop-formatting
branch
from
c5a1955
to
bfea797
Compare
nschonni
force-pushed
the
rubocop-formatting
branch
from
bfea797
to
6c1b69d
Compare
|
I've undone all the line ending changes to make this easier to land. This is now just a run of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reduce the number of unrelated annotations on the PRs when the specific code isn't being touched. This only was run for formatting related rules.
Ran
bundle exec rubocop -xwith the linelength set to 1400 on the first pass.