Remove clustering from streaming API #23518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
ThisIsMissEm
reviewed
Mar 7, 2023
| const startWorker = async (workerId) => { | ||
| log.warn(`Starting worker ${workerId}`); | ||
|
|
||
| const startWorker = async () => { |
There was a problem hiding this comment.
Suggested change
| const startWorker = async () => { | |
| const startServer = async () => { |
| master: startMaster, | ||
| }); | ||
| }); | ||
| startWorker(); |
There was a problem hiding this comment.
Suggested change
| startWorker(); | |
| startServer(); |
These two changes get rid of the verbage of workers from this code.
|
@Gargron I'm currently looking into how this code could be improved further, and I'm suspecting that the current redis setup for pub/sub is inefficient (that is, the topic model doesn't actually fit with how streaming is working in the wild in production environments) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.