Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unintended SMTP read timeout from 5 seconds to 20 seconds #23750

Merged
merged 1 commit into from Mar 3, 2023
Merged

Change unintended SMTP read timeout from 5 seconds to 20 seconds #23750

merged 1 commit into from Mar 3, 2023

Conversation

ClearlyClaire
Copy link
Contributor

Fixes #23727

@ClearlyClaire ClearlyClaire mentioned this pull request Feb 20, 2023
Closed
@ClearlyClaire ClearlyClaire marked this pull request as draft February 21, 2023 08:59
@ClearlyClaire
Copy link
Contributor Author

Converted back to a draft because of a report it does not fix the issue. Will need more investigation.

@ClearlyClaire ClearlyClaire changed the title Change unintended SMTP timeouts from 5 seconds to 10 seconds Change unintended SMTP timeouts from 5 seconds to 20 seconds Feb 21, 2023
@ClearlyClaire ClearlyClaire marked this pull request as ready for review February 21, 2023 13:17
@ClearlyClaire ClearlyClaire changed the title Change unintended SMTP timeouts from 5 seconds to 20 seconds Change unintended SMTP read timeout from 5 seconds to 20 seconds Feb 22, 2023
@ClearlyClaire
Copy link
Contributor Author

After some more investigation, this seems like a SMTP server issue, but considering that:

  • at least two different admins were affected
  • we were not able to identify the root cause
  • the failure mode is annoying (duplicate mails)
  • this was not an issue when we did not have a timeout

I think it makes sense to increase the read_timeout (the default open_timeout of 5 seconds should be fine, as it is not the issue that has been encountered, and the failure mode is less annoying)

@Gargron Gargron merged commit 02c6bad into mastodon:main Mar 3, 2023
ClearlyClaire added a commit that referenced this pull request Mar 14, 2023
@ClearlyClaire
Change unintended SMTP read timeout from 5 seconds to 20 seconds (#23750
2a37dc7 
)
arachnist pushed a commit to arachnist/mastodon that referenced this pull request Apr 4, 2023
@ClearlyClaire @arachnist
Change unintended SMTP read timeout from 5 seconds to 20 seconds (mas…
0de360f 
…todon#23750)
Roboron3042 pushed a commit to Roboron3042/mastodon that referenced this pull request Apr 16, 2023
@ClearlyClaire
Change unintended SMTP read timeout from 5 seconds to 20 seconds (mas…
1b6bd2e 
…todon#23750)
skerit pushed a commit to 11ways/mastodon that referenced this pull request Jul 7, 2023
@ClearlyClaire @skerit
Change unintended SMTP read timeout from 5 seconds to 20 seconds (mas…
119fcd9 
…todon#23750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate email notifications after 4.1.0 update
2 participants
@ClearlyClaire @Gargron