Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast of upload progress background #23836

Merged

Conversation

toolmantim
Copy link
Contributor

Hi there! This is my first contribution, so please let me know if there's anything you'd like changed / adjusted 👋🏼

When using either of the dark themes, it is very difficult to see the progress of a file upload due to the low contrast between the blue bar and the background color.

This PR updates the background color (using the compose dialog as reference) so you can now more clearly see the progress of your file upload.

Theme Before After
Dark before-dark after-dark
High Contrast before-dark-high-contrast after-dark-high-contrast
Light before-light after-light

@toolmantim
Copy link
Contributor Author

Not sure what's happening with CircleCI there. I configured my fork and triggered a rebuild (see toolmantim@3136ff3 which has the ✅) in the hope that it would fix it — still no status report here on the main repo though.

@Gargron Gargron merged commit f4f91bc into mastodon:main Feb 23, 2023
@toolmantim toolmantim deleted the fix-upload-progress-bar-color-contrast branch February 23, 2023 12:29
@shleeable
Copy link
Contributor

shleeable commented Feb 23, 2023

Thank you. The light/dark difference of that bar was non-existent to my eyes.

emtkmkk pushed a commit to emtkmkk/mastodon that referenced this pull request Mar 12, 2023
Roboron3042 pushed a commit to Roboron3042/mastodon that referenced this pull request Apr 16, 2023
skerit pushed a commit to 11ways/mastodon that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants