add modal message when editing toot #23936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Mar 6, 2023
Comment on lines
165
to
166
| "confirmations.edit.confirm": "Editar", | ||
| "confirmations.edit.message": "Editar agora sobrescreverá o toot que você está compondo. Deseja continuar?", |
There was a problem hiding this comment.
Looks good overall, but changing translation files directly runs a risk of creating merge conflicts with the automated Crowdin PRs. It's safer to change only en.json in PRs and then change the translations in Crowdin.
There was a problem hiding this comment.
Ok I'm fixing this
PauloVilarinho
force-pushed
the
add-modal-messages-when-editing-toot
branch
from
e65e289
to
e28303f
Compare
ClearlyClaire
approved these changes
Mar 6, 2023
ClearlyClaire
pushed a commit
that referenced
this pull request
Mar 14, 2023
Co-authored-by: PauloVilarinho <paulotarsobranco@hotmail.com>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/mastodon
that referenced
this pull request
Mar 19, 2023
Co-authored-by: PauloVilarinho <paulotarsobranco@hotmail.com>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/mastodon
that referenced
this pull request
Mar 19, 2023
Co-authored-by: PauloVilarinho <33267902+PauloVilarinho@users.noreply.github.com> Co-authored-by: PauloVilarinho <paulotarsobranco@hotmail.com>
arachnist
pushed a commit
to arachnist/mastodon
that referenced
this pull request
Apr 4, 2023
Co-authored-by: PauloVilarinho <paulotarsobranco@hotmail.com>
Roboron3042
pushed a commit
to Roboron3042/mastodon
that referenced
this pull request
Apr 16, 2023
Co-authored-by: PauloVilarinho <paulotarsobranco@hotmail.com>
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Co-authored-by: PauloVilarinho <paulotarsobranco@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22851
This PR adds a modal when there is text on the compose form and the user clicks on the edit button on another toot.
I was not able to find where to add tests for this one. If anyone can help me with this problem I would be very grateful.