Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change design of account rows in web UI #24247

Merged
merged 1 commit into from Mar 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 47 additions & 6 deletions app/javascript/mastodon/components/account.jsx
Expand Up @@ -10,6 +10,9 @@ import { me } from '../initial_state';
import RelativeTimestamp from './relative_timestamp';
import Skeleton from 'mastodon/components/skeleton';
import { Link } from 'react-router-dom';
import { counterRenderer } from 'mastodon/components/common_counter';
import ShortNumber from 'mastodon/components/short_number';
import Icon from 'mastodon/components/icon';

const messages = defineMessages({
follow: { id: 'account.follow', defaultMessage: 'Follow' },
Expand All @@ -23,6 +26,26 @@ const messages = defineMessages({
block: { id: 'account.block', defaultMessage: 'Block @{name}' },
});

class VerifiedBadge extends React.PureComponent {

static propTypes = {
link: PropTypes.string.isRequired,
verifiedAt: PropTypes.string.isRequired,
};

render () {
const { link } = this.props;

return (
<span className='verified-badge'>
<Icon id='check' className='verified-badge__mark' />
<span dangerouslySetInnerHTML={{ __html: link }} />
</span>
);
}

}

class Account extends ImmutablePureComponent {

static propTypes = {
Expand Down Expand Up @@ -77,7 +100,11 @@ class Account extends ImmutablePureComponent {
<div className='account__wrapper'>
<div className='account__display-name'>
<div className='account__avatar-wrapper'><Skeleton width={36} height={36} /></div>
<DisplayName />

<div>
<DisplayName />
<Skeleton width='7ch' />
</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -131,18 +158,32 @@ class Account extends ImmutablePureComponent {
}
}

let mute_expires_at;
let muteTimeRemaining;

if (account.get('mute_expires_at')) {
mute_expires_at = <div><RelativeTimestamp timestamp={account.get('mute_expires_at')} futureDate /></div>;
muteTimeRemaining = <>· <RelativeTimestamp timestamp={account.get('mute_expires_at')} futureDate /></>;
}

let verification;

const firstVerifiedField = account.get('fields').find(item => !!item.get('verified_at'));

if (firstVerifiedField) {
verification = <>· <VerifiedBadge link={firstVerifiedField.get('value')} verifiedAt={firstVerifiedField.get('verified_at')} /></>;
}

return (
<div className='account'>
<div className='account__wrapper'>
<Link key={account.get('id')} className='account__display-name' title={account.get('acct')} to={`/@${account.get('acct')}`}>
<div className='account__avatar-wrapper'><Avatar account={account} size={size} /></div>
{mute_expires_at}
<DisplayName account={account} />
<div className='account__avatar-wrapper'>
<Avatar account={account} size={size} />
</div>

<div>
<DisplayName account={account} />
<ShortNumber value={account.get('followers_count')} renderer={counterRenderer('followers')} /> {verification} {muteTimeRemaining}
</div>
</Link>

<div className='account__relationship'>
Expand Down
29 changes: 22 additions & 7 deletions app/javascript/styles/mastodon/components.scss
Expand Up @@ -1403,10 +1403,12 @@ body > [data-popper-placement] {
text-decoration: none;
font-size: 14px;

&--with-note {
strong {
display: inline;
}
.display-name {
margin-bottom: 4px;
}

.display-name strong {
display: inline;
}
}

Expand Down Expand Up @@ -1629,7 +1631,7 @@ a .account__avatar {

.status__display-name,
.account__display-name {
strong {
.display-name strong {
color: $primary-text-color;
}
}
Expand All @@ -1644,12 +1646,12 @@ a .account__avatar {
.reply-indicator__display-name,
.detailed-status__display-name,
a.account__display-name {
&:hover strong {
&:hover .display-name strong {
text-decoration: underline;
}
}

.account__display-name strong {
.account__display-name .display-name strong {
display: block;
overflow: hidden;
text-overflow: ellipsis;
Expand Down Expand Up @@ -7356,6 +7358,19 @@ noscript {
}
}

.verified-badge {
display: inline-flex;
align-items: center;
color: $valid-value-color;
gap: 4px;

a {
color: inherit;
font-weight: 500;
text-decoration: none;
}
}

.trends {
&__header {
color: $dark-text-color;
Expand Down