Feat: allow filter original statuses on user profile #24267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmmyZhang
force-pushed
the
account-statuses-no-reblog
branch
from
2924291
to
829d4d4
Compare
imo it would be better if there were no tabs at all, just posts, and everything was a switch -- include replies, include boosts, include media |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
OmmyZhang
force-pushed
the
account-statuses-no-reblog
branch
from
829d4d4
to
ce0649e
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
OmmyZhang
force-pushed
the
account-statuses-no-reblog
branch
2 times, most recently
from
d7ebe87
to
cf2d022
Compare
OmmyZhang
force-pushed
the
account-statuses-no-reblog
branch
from
cf2d022
to
a2d3309
Compare
|
整挺好 |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
@jiangshanghan Could you please remove your comment? It's somehow inappropriate. 可以删掉你的评论吗，不太合适。 |
|
please do not scream like that. my comments had no offense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend parameter is already added 5 years ago #9640 .
I continue to see users complaining that when they process follow requests, they sometimes have to spend a long time finding a original status. Therefore, I believe this feature is very useful.
I agree that one more column may not be suitable for small-screen phones and multi-column UI, especially after there's the sidebar since 4.0. So I add a switch. In the future, perhaps we can also change withReplies to a switch and keep only 2 columns.
How it looks:
This change also incidentally brings some minor optimizations to the display of loading. Returning a full screen
<LoadingIndicator>is only necessary when account info is not ready, otherwise theisLoadingof<StatusList>just works fine.Close #18413 .
Some other related issues: #10011 #20575 #21418 .