Rewrite AvatarOverlay component with React hooks #24543
Conversation
takayamaki
force-pushed
the
refactor/AvatarOverlay
branch
from
49c7ae3
to
d9844b0
Compare
| hovering: false, | ||
| }; | ||
|
|
||
| handleMouseEnter = () => { |
There was a problem hiding this comment.
Both event handler function object of handleMouseEnter and handleMouseLeave are unused this component.
|
|
||
| return ( | ||
| <div className='account__avatar-overlay' style={{ width: size, height: size }}> | ||
| <div className='account__avatar-overlay-base'><Avatar animate={hovering || animate} account={account} size={baseSize} /></div> |
There was a problem hiding this comment.
No need to pass animate arguments to Avatar component why they have hovering state and its event handler in themself.
There was a problem hiding this comment.
Looks like the event handlers were not hooked up but I think the intent was that both avatars would play at the same time when the overlay was hovered.
There was a problem hiding this comment.
Looks like the event handlers were not hooked up but I think the intent was that both avatars would play at the same time when the overlay was hovered.
I seem so too.
I will fix it
This movie is behavior of current main branch(e5c0b16).
admin.@admin@localhost_3000.-.Mastodon.Dev.-.Google.Chrome.2023-04-16.14-58-24.mp4
There was a problem hiding this comment.
I made a commit.
b1397f8
admin.@admin@localhost_3000.-.Mastodon.Dev.-.Google.Chrome.2023-04-16.16-59-09.mp4
| static propTypes = { | ||
| account: ImmutablePropTypes.map.isRequired, | ||
| friend: ImmutablePropTypes.map.isRequired, | ||
| animate: PropTypes.bool, |
There was a problem hiding this comment.
animate argument is unused.
takayamaki
force-pushed
the
refactor/AvatarOverlay
branch
from
d9844b0
to
d770fd2
Compare
For playing same time, do not attach event handlers to inner elements.
takayamaki
force-pushed
the
refactor/AvatarOverlay
branch
from
d770fd2
to
b1397f8
Compare
This PR rewrites AvatarOverlay component with React hooks.
And fix animation behavior when component hoverd.