Upgrade react-rails to v2.x #2465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure jquery had a use. |
|
jQuery is breaks DOM node created by React. |
|
Without jQuery I get these messages : |
|
@Wonderfall Oh, I'm sorry. I overlooked it. I think that it is corrected by a373e0f. |
3 tasks
|
Because it conflicts with #2617 it closes. |
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Nov 15, 2023
Fix relative / VS absolute style imports, and fix whitespace discrepancies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry! There are many file changes. But, I just added
import React from 'react';.Also, never use jQuery in React Components. I deleted
//= require jquery.with jQuery
without jQuery