-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role badges on public #24729
Add role badges on public #24729
Conversation
New account component for account badges and implemented on a few places on the public UI. Supports the public toggle and color definition from admin.
New new strings, but removed 'Group' as the account badge is using the text entered by the admin
Hi! Thank you for your contribution! When making UI changes, please try to provide screenshots with your PRs! The check-i18n failure is because your commit 9ecee34 added a newline at the end of the Also, just for your information, there is another PR trying to solve this with a different design (#21393), although we are not quite sure what design to go with for now, but the main thing that looks off with your PR is how the badges are rendered in posts. It would probably be ok leaving them out of this view. |
Yeah, I noticed the newline issue, but hadn't had a chance to commit the fix yet. Also screenshots! I posted them in #20031 but forgot to do so here, (I tend to forget that merge requests and issues are duplicates of each other for some weird reason...) I didn't change the UI of the existing badges, just expanded support for |
I meant the addition of badges in posts (your changes to Otherwise, it looks good to me, but we'll wait for feedback from our designer. |
This pull request has merge conflicts that must be resolved before it can be merged. |
you are cool |
Fixes #19922
New account component for account badges and implemented on a few places on the public UI. Supports the public toggle and color definition from admin.