Add aria-label to icon driven dropdown menus #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Apr 27, 2017
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to follow the suggestions made by font awesome and just add the
aria-labelto the link itself. This also allows for the text placed here to be pass in so that all places that use this drop down component should have the increased a11y (defaulted to "Menu" so it's there no matter what).Closes #1953
I'd like to add some tests on this but I wasn't entirely sure how to run the javascript tests (if someone can show me I will gladly add (though there's not much really to be tested).