Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect pagination headers in /api/v2/admin/accounts #25477

Merged
merged 1 commit into from Jun 19, 2023
Merged

Fix incorrect pagination headers in /api/v2/admin/accounts #25477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/controllers/api/v2/admin/accounts_controller.rb
View file
Open in desktop
Expand Up @@ -18,6 +18,14 @@ class Api::V2::Admin::AccountsController < Api::V1::Admin::AccountsController

private

def next_path
api_v2_admin_accounts_url(pagination_params(max_id: pagination_max_id)) if records_continue?
end

def prev_path
api_v2_admin_accounts_url(pagination_params(min_id: pagination_since_id)) unless @accounts.empty?
end

def filtered_accounts
AccountFilter.new(translated_filter_params).results
end
Expand Down
8 changes: 8 additions & 0 deletions spec/controllers/api/v2/admin/accounts_controller_spec.rb
View file
Open in desktop
Expand Up @@ -55,5 +55,13 @@
end
end
end

context 'with limit param' do
let(:params) { { limit: 1 } }

it 'sets the correct pagination headers' do
expect(response.headers['Link'].find_link(%w(rel next)).href).to eq api_v2_admin_accounts_url(limit: 1, max_id: admin_account.id)
end
end
end
end