Use envify + NODE_ENV=production for smaller JS bundle #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just double-checked, and this also correctly uses |
|
Shouldn't |
|
Yes, I added it to the |
|
Yes but it fails (module can't be found) when |
|
What do you mean "it fails"? In this PR I'm not even setting |
|
Ah wait, I forgot to update |
3 tasks
|
Note that #2617 would make this PR obsolete. |
|
As foretold, obsolete through #2617 :P |
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Feb 20, 2024
* Further reduce CSS differences with upstream * Reduce differences in markup and CSS with upstream * Redo collapsible post notifications * Reduce CSS differences further * Reduce differences with upstream regarding `.status` and `.status__wrapper` * Further reduce differences with upstream * Reduce differences with upstream in DisplayName
fad0805
pushed a commit
to fad0805/daydream.ink
that referenced
this pull request
Feb 26, 2024
* Further reduce CSS differences with upstream * Reduce differences in markup and CSS with upstream * Redo collapsible post notifications * Reduce CSS differences further * Reduce differences with upstream regarding `.status` and `.status__wrapper` * Further reduce differences with upstream * Reduce differences with upstream in DisplayName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses envify as a global Browserify transform to replace usages of
process.env.NODE_ENVwith"production"whenRAILS_ENVis also set to"production", which allows Uglify to remove non-essential code. It also makes it soreact-addons-perfis omitted in production mode, since it's not worthwhile in production (it just instrumentsperformance.mark/performance.measures in React's APIs).Before this PR,
application.jsis 2.96 MB (2963246 bytes to be exact, 514 kB gzipped). After, it's 2.95 MB (2952387 bytes to be exact, 512 kB gzipped).