Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post translation erroring out (v4.1.x) #26990

Merged
merged 2 commits into from Sep 20, 2023
Merged

Fix post translation erroring out (v4.1.x) #26990

merged 2 commits into from Sep 20, 2023

Conversation

ClearlyClaire
Copy link
Contributor

Fixes #26983

@ClearlyClaire ClearlyClaire added the bug Something isn't working label Sep 20, 2023
@ClearlyClaire ClearlyClaire requested a review from a team September 20, 2023 08:04
@ClearlyClaire ClearlyClaire changed the title Fix post translation erroring out Fix post translation erroring out (v4.1.x) Sep 20, 2023
@msviba
Copy link

msviba commented Sep 20, 2023

It works for me. Just previously cached translations still returning 500. But its not problem. Thanks

@renchap
Copy link
Sponsor Member

renchap commented Sep 20, 2023

Looks good. Should we bump the cache version so old non-sanitized translations are not re-used?

@ClearlyClaire
Copy link
Contributor Author

Looks good. Should we bump the cache version so old non-sanitized translations are not re-used?

I don't think it's a big deal but it makes sense. Adding that.

@ClearlyClaire ClearlyClaire merged commit 5d93c5f into mastodon:stable-4.1 Sep 20, 2023
2 checks passed
This was referenced Sep 20, 2023
Merged
Merged
@hugogameiro hugogameiro mentioned this pull request Sep 20, 2023
Closed
walfie pushed a commit to kirakiratter/mastodon that referenced this pull request Sep 21, 2023
@ClearlyClaire @walfie
Fix post translation erroring out (v4.1.x) (mastodon#26990)
b9816f3
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 3, 2023
@nrdufour
chore(deps): update ghcr.io/mastodon/mastodon docker tag to v4.1.9 (#99)
5ae42dd 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/mastodon/mastodon](https://github.com/mastodon/mastodon) | patch | `v4.1.8` -> `v4.1.9` |

---

### Release Notes

<details>
<summary>mastodon/mastodon (ghcr.io/mastodon/mastodon)</summary>

### [`v4.1.9`](https://github.com/mastodon/mastodon/releases/tag/v4.1.9)

[Compare Source](mastodon/mastodon@v4.1.8...v4.1.9)

<h1><picture>
  <source media="(prefers-color-scheme: dark)" srcset="./lib/assets/wordmark.dark.png?raw=true">
  <source media="(prefers-color-scheme: light)" srcset="./lib/assets/wordmark.light.png?raw=true">
  <img alt="Mastodon" src="./lib/assets/wordmark.light.png?raw=true" height="34">
</picture></h1>

> This release addresses an issue that was introduced by the last security update and includes changelogs for both updates.
>
> **:warning: This is a follow-up to the important 4.1.8 security update that fixed major security issues (CVE-2023-42451, CVE-2023-42452).**
>
> Corresponding security releases are available for the [4.0.x branch](https://github.com/mastodon/mastodon/releases/tag/v4.0.10) and the [3.5.x branch](https://github.com/mastodon/mastodon/releases/tag/v3.5.14).
> If you are using nightly builds, **do not use this release** but update to `nightly.2023-09-20` or newer instead. If you are on the `main` branch, update to the latest commit.

##### Changelog (v4.1.9)

##### Fixed

-   Fix post translation erroring out ([ClearlyClaire](mastodon/mastodon#26990))

##### Changelog (v4.1.8)

##### Fixed

-   Fix post edits not being forwarded as expected ([ClearlyClaire](mastodon/mastodon#26936))
-   Fix moderator rights inconsistencies ([ClearlyClaire](mastodon/mastodon#26729))
-   Fix crash when encountering invalid URL ([ClearlyClaire](mastodon/mastodon#26814))
-   Fix cached posts including stale stats ([ClearlyClaire](mastodon/mastodon#26409))
-   Fix uploading of video files for which `ffprobe` reports `0/0` average framerate ([NicolaiSoeborg](mastodon/mastodon#26500))
-   Fix unexpected audio stream transcoding when uploaded video is eligible to passthrough ([yufushiro](mastodon/mastodon#26608))

##### Security

-   Fix missing HTML sanitization in translation API (CVE-2023-42452, [GHSA-2693-xr3m-jhqr](GHSA-2693-xr3m-jhqr))
-   Fix incorrect domain name normalization (CVE-2023-42451, [GHSA-v3xf-c9qf-j667](GHSA-v3xf-c9qf-j667))

##### Upgrade notes

To get the code for v4.1.9, use `git fetch && git checkout v4.1.9`.

> As always, **make sure you have backups of the database before performing any upgrades**. If you are using docker-compose, this is how a backup command might look: `docker exec mastodon_db_1 pg_dump -Fc -U postgres postgres > name_of_the_backup.dump`

##### Dependencies

External dependencies have not changed compared to v4.1.7, the compatible Ruby, PostgreSQL, Node, Elasticsearch and Redis versions are the same, that is:

-   Ruby: 2.7 to 3.0
-   PostgreSQL: 9.5 or newer
-   Elasticsearch (optional, for full-text search): 7.x
-   Redis: 4 or newer
-   Node: >= 14, < 18
-   ImageMagick: 6.9.7-7 or newer

> If your uploaded images are broken after the upgrade, it means your installed ImageMagick version is older than the new minimum version (6.9.7-7), for example if you are running Ubuntu 18.04. If this happens, you can find more information and ways to fix it [on this page](mastodon/mastodon#25776).

##### Update steps

The following instructions are for updating from 4.1.7 or 4.1.8.

If you are upgrading directly from an earlier release, please carefully read the upgrade notes for the skipped releases as well, as they often require extra steps such as database migrations.

**Non-Docker only:**

1.  Install dependencies: `bundle install` and `yarn install --frozen-lockfile`

**Both Docker and non-Docker:**

1.  Restart all Mastodon processes

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4zIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/99
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renchap renchap renchap approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClearlyClaire @msviba @renchap