Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line wrapping of language selection button with long locale codes #27100

Merged
merged 1 commit into from Sep 25, 2023
Merged

Fix line wrapping of language selection button with long locale codes #27100

merged 1 commit into from Sep 25, 2023

Conversation

gunchleoc
Copy link
Contributor

Fixes #26967 and #19302

ClearlyClaire
ClearlyClaire approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this will still leave an issue where the button's bounding box is smaller than its text contents.

Maybe that can be fixed by using max-width rather than width for the computed button width.

@ClearlyClaire ClearlyClaire merged commit 88fa8e7 into mastodon:main Sep 25, 2023
31 checks passed
@ClearlyClaire ClearlyClaire mentioned this pull request Sep 25, 2023
Merged
@gunchleoc gunchleoc deleted the 26967-locale-code-wrap branch September 26, 2023 17:53
audiodude pushed a commit to audiodude/mastodon that referenced this pull request Oct 23, 2023
@gunchleoc @audiodude
Fix line wrapping of language selection button with long locale codes (…
5ed30da 
…mastodon#27100)
@ClearlyClaire ClearlyClaire mentioned this pull request Dec 6, 2023
Closed
000hen pushed a commit to thenapnetwork/nap-mastodon that referenced this pull request Dec 6, 2023
@gunchleoc @000hen
Fix line wrapping of language selection button with long locale codes (…
04578bf 
…mastodon#27100)
vmstan pushed a commit to vmstan/mastodon that referenced this pull request Jan 5, 2024
@gunchleoc @vmstan
Fix line wrapping of language selection button with long locale codes (…
dd9041f 
…mastodon#27100)
ClearlyClaire pushed a commit that referenced this pull request Jan 15, 2024
@gunchleoc @ClearlyClaire
Fix line wrapping of language selection button with long locale codes (…
c8cf347 
…#27100)
@ClearlyClaire ClearlyClaire mentioned this pull request Jan 23, 2024
Merged
ClearlyClaire pushed a commit that referenced this pull request Jan 24, 2024
@gunchleoc @ClearlyClaire
Fix line wrapping of language selection button with long locale codes (…
e8c5754 
…#27100)
ttrace pushed a commit to ttrace/mastodon that referenced this pull request Feb 2, 2024
@gunchleoc @ttrace
Fix line wrapping of language selection button with long locale codes (…
8921756 
…mastodon#27100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post language button wrapped into two lines when zh-CN/HK/TW/YUE was selected
2 participants
@gunchleoc @ClearlyClaire