Switch from yarn to pnpm

[renchap]

This is al alternative to #27073

Yarn 1 is no longer maintained and suffers from many bugs (including eslint/eslint#17215 (reply in thread) which prevents multiple package upgrades)

pnpm is a more modern package manager, which should be much faster and generate a more correct node_modules/

The two main changes are:

• pnpm maintains a global package repository on your machine. Then it links those packages into node_modules/, which makes installation much more efficient and reduces the disk usage if you have many JS projects on your computer
• only direct dependencies are linked into node_modules/. For example, tesseract.js-core was not defined as a dependency but was imported from a JS file, causing an error, so I added it as an explicit dependency.

As Webpacker relies on yarn, I monkey-patched the parts that called yarn directly to replace it with pnpm.

Our setup should now properly support corepack, so installing the package manager is as simple as corepack prepare --activate (and maybe corepack enable before, if it has never been ran on this machine and is not down when installing node). It will automatically install the correct pnpm version.

This PR is based on #27295 as we can no longer use capitrano-yarn, and Capistrano is not tested so I removed it.

[nschonni]

Probably a good choice, but you'll have to look at the Dockerfile stuff, since the official images only ship with NPM and Yarn1. I know there are a few Docker related PRs active right now, that might move off the official NodeJS image

[renchap]

Probably a good choice, but you'll have to look at the Dockerfile stuff, since the official images only ship with NPM and Yarn1. I know there are a few Docker related PRs active right now, that might move off the official NodeJS image

I switched the docker images to using corepack, which will handle installing the correct JS package manager automatically, using the packageManager field from package.json.

[vmstan]

Probably a good choice, but you'll have to look at the Dockerfile stuff, since the official images only ship with NPM and Yarn1. I know there are a few Docker related PRs active right now, that might move off the official NodeJS image

I've been working on one of them, and have it setup to test this and worked with Renchap to get a successful build on it today.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[ClearlyClaire]

Switching from our current yarn version to anything else will require significant changes for admins (unless using docker), and the documentation will need to be updated.

I ran into multiple issues setting up corepack on my setups, but to be fair, I had other issues with yarn 1.

For some reason, on my ArchLinux-based development environment, the husky hook now somehow picks up the wrong bundle environment. I don't understand what is causing this nor how to fix it.
Manually running bundle exec rubocop --force-exclusion -a works without issues.
EDIT: This issue isn't specific to pnpm

Also, should we change something to the Renovate config?~~

[renchap]

For some reason, on my ArchLinux-based development environment, the husky hook now somehow picks up the wrong bundle environment. I don't understand what is causing this nor how to fix it:

What node version manager are you using? This is very weird, I am not sure what is happening here 🤔

[ClearlyClaire]

What node version manager are you using? This is very weird, I am not sure what is happening here 🤔

v18.18.0

[renchap]

Also, should we change something to the Renovate config?~~

Nothing specific, we use matchManagers: ['npm'], which will work with every JS package manager.

The currently open PRs will probably need to be rebased, but Renovate should do it.

the documentation will need to be updated.

I did it for documentation in this repo, but as the main documentation is not versioned, I will probably need to add specific instructions for Mastodon >= 4.3 everywhere yarn is mentioned :(

Do you want me to open the PR for this now, or should we do it closer to the 4.3 release?

[renchap]

Rebased with latest main, if you want to merge it :)

[github-actions]

This pull request has resolved merge conflicts and is ready for review.

[vmstan]

Rebased with latest main, if you want to merge it :)

Compiled and running it in prod, no errors.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[renchap]

Closing as #27073 has been merged.