Fix duplicate reports being sent when reporting some remote posts #27355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a remote post in reply to the same server is replied to, Mastodon may send two copies of the `Flag` payload: one for the reported user, and one for people being replied to.
ClearlyClaire
added
bug
renchap
approved these changes
Oct 10, 2023
ClearlyClaire
added a commit
that referenced
this pull request
Oct 10, 2023
ClearlyClaire
added a commit
that referenced
this pull request
Oct 10, 2023
kmycode
pushed a commit
to kmycode/mastodon
that referenced
this pull request
Oct 11, 2023
audiodude
pushed a commit
to audiodude/mastodon
that referenced
this pull request
Oct 23, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a remote post in reply to the same server is replied to, Mastodon may send two copies of the
Flagactivity: one for the reported user, and one for people being replied to.This is because the report is sent to the reported account's personal inbox (not changed, in case other software rely on this) and reports to replied-to users are sent using shared inbox, with the existing deduplication logic not accounting for this discrepancy.