Fixes #23135 - Allow cross origin request for /nodeinfo/2.0 API #27413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Oct 16, 2023
kmycode
pushed a commit
to kmycode/mastodon
that referenced
this pull request
Oct 17, 2023
audiodude
pushed a commit
to audiodude/mastodon
that referenced
this pull request
Oct 23, 2023
000hen
pushed a commit
to thenapnetwork/nap-mastodon
that referenced
this pull request
Dec 6, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #23135, missing CORS headers on
/nodeinfo/2.0endpoint are an issue for any web pages supposed to work with different Fediverse applications. While the proper approach to determine the software running on a Fediverse instance would be downloading/.well-known/nodeinfoand then/nodeinfo/2.0, the latter currently fails for Mastodon. I’ve hit this issue myself when implementing “Share to Fediverse” functionality.Adding CORS headers for
/nodeinfo/2.0is trivial. And given that the information produced is public, there is no reason CORS headers shouldn’t be there.