Add HTML lang attribute to preview card descriptions #27503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srapilly
changed the title
Gargron
approved these changes
Oct 23, 2023
vmstan
added
javascript
ClearlyClaire
changed the title
ponapalt
pushed a commit
to ponapalt/mastodon
that referenced
this pull request
Oct 29, 2023
zunda
pushed a commit
to zunda/mastodon
that referenced
this pull request
Oct 29, 2023
audiodude
pushed a commit
to audiodude/mastodon
that referenced
this pull request
Nov 16, 2023
000hen
pushed a commit
to thenapnetwork/nap-mastodon
that referenced
this pull request
Dec 6, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html lang attribute is present for the title and card provider, but it was not present for the description.
I also saw it was not in the https://docs.joinmastodon.org/entities/PreviewCard/ documentation