New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix streaming API redirection ignoring the port of streaming_api_base_url
#28558
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28558 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 1039 1039
Lines 28238 28240 +2
Branches 4550 4550
=======================================
+ Hits 23889 23891 +2
Misses 3197 3197
Partials 1152 1152 ☔ View full report in Codecov by Sentry. |
streaming_api_base_url
streaming_api_base_url
I think the check of |
You are right, this comparison will always evaluate to false, as |
See #28539 (comment)