-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API::Pagination
concern
#28826
Add API::Pagination
concern
#28826
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28826 +/- ##
==========================================
+ Coverage 85.01% 85.05% +0.04%
==========================================
Files 1059 1039 -20
Lines 28277 28092 -185
Branches 4538 4532 -6
==========================================
- Hits 24040 23894 -146
+ Misses 3074 3038 -36
+ Partials 1163 1160 -3 ☔ View full report in Codecov by Sentry. |
The two linked PRs here show some possible future additions to this concern. |
4b039ef
to
e855e2a
Compare
e855e2a
to
d88a423
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
d88a423
to
2a34c30
Compare
Rebased this after the max/since one merged. This is probably ready to go as well, but let me know if this would be easier to review in smaller chunks. I could probably pull out the new matcher and spec changes into separate PR, and possibly do the concern changes in 2-3 PRs as well. Separately, the linked pagination params PR - #28845 - should either be merged first and then incorporated into this change; or if this is merged first, it should be updated to move things to the concern instead of the base class. |
This pull request has resolved merge conflicts and is ready for review. |
This pull request has merge conflicts that must be resolved before it can be merged. |
2a34c30
to
f441070
Compare
This pull request has resolved merge conflicts and is ready for review. |
f441070
to
06c5951
Compare
06c5951
to
616d834
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
616d834
to
0333c1f
Compare
This pull request has resolved merge conflicts and is ready for review. |
0333c1f
to
f48feb5
Compare
f48feb5
to
a73b58c
Compare
Several related changes:
API::Pagination
concern, and put the existing pagination methods from the api base controller into itinsert_pagination_headers
before_action. Move this to the newly created concern.I think there is room for more future improvement in this area, but didn't want to go much further than this in first pass.