Fix 'focus the compose textarea' shortcut is not working #29059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Feb 2, 2024
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes made in #28119,
.compose-form__autosuggest-wrapperhas been removed. As a result, the shortcut key to move to the post input field is not working. This is because we relied on the class name mentioned above to get the input field for the post.When I read the code, it seems that the input field always has the class name
.autosuggest-textarea__textarea, so I'll change it to use this to look for the input field.I know this is not an elegant fix, but it should work.