Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nsa gem to version 0.3.0 #29065

Merged
merged 1 commit into from Feb 6, 2024
Merged

Update nsa gem to version 0.3.0 #29065

merged 1 commit into from Feb 6, 2024

Conversation

mjankowski
Copy link
Contributor

Moves us off a PR branch and onto released gem version (with Rails 7 support).

ClearlyClaire
ClearlyClaire approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find changelog entries or a commit history, the update does not seem to be on the github repository… but the changes from the version we use are fine, and there's actually another unrelated bugfix. LGTM.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 6, 2024
Merged via the queue into mastodon:main with commit 5ca4540 Feb 6, 2024
30 checks passed
@Gargron
Copy link
Member

Gargron commented Feb 6, 2024

I think we want to remove this gem since it introduces performance issues and we’re moving towards OpenTelemetry instead.

@ClearlyClaire
Copy link
Contributor

Yes, we want to remove it eventually.

@mjankowski mjankowski deleted the nsa-gem branch February 6, 2024 14:25
ClearlyClaire pushed a commit to ClearlyClaire/mastodon that referenced this pull request Feb 6, 2024
@mjankowski @ClearlyClaire
Update nsa gem to version 0.3.0 (mastodon#29065)
4cd00c0
neatchee pushed a commit to neatchee/mastodon that referenced this pull request Feb 9, 2024
@mjankowski @neatchee
Update nsa gem to version 0.3.0 (mastodon#29065)
cc15016
ClearlyClaire pushed a commit that referenced this pull request Feb 14, 2024
@mjankowski @ClearlyClaire
Update nsa gem to version 0.3.0 (#29065)
7d6662e
ClearlyClaire pushed a commit that referenced this pull request Feb 14, 2024
@mjankowski @ClearlyClaire
Update nsa gem to version 0.3.0 (#29065)
a1c61b9
ClearlyClaire added a commit that referenced this pull request Feb 14, 2024
@ClearlyClaire @mjankowski
Update nsa gem to version 0.3.0 (#29065) (#29206)
e4ec4ce 
Co-authored-by: Matt Jankowski <matt@jankowski.online>
kmycode pushed a commit to kmycode/mastodon that referenced this pull request Feb 14, 2024
@ClearlyClaire @mjankowski @kmycode
Update nsa gem to version 0.3.0 (mastodon#29065) (mastodon#29206)
7d3899d 
Co-authored-by: Matt Jankowski <matt@jankowski.online>
ttrace pushed a commit to ttrace/mastodon that referenced this pull request Feb 15, 2024
@ClearlyClaire @mjankowski @ttrace
Update nsa gem to version 0.3.0 (mastodon#29065) (mastodon#29206)
05f4e4c 
Co-authored-by: Matt Jankowski <matt@jankowski.online>
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
@mjankowski @skerit
Update nsa gem to version 0.3.0 (mastodon#29065)
80e0dc1
This was referenced May 10, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjankowski @Gargron @ClearlyClaire