Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return domain block digests from admin domain blocks API #29092

Conversation

ThisIsMissEm
Copy link
Contributor

Whilst developing IFTAS FediCheck, we noticed that the public API for domain blocks /api/v1/domain_blocks returns the digest property, but the admin API /api/v1/admin/domain_blocks did not, which meant we couldn't rely on the domain digest and had to instead match on the domain itself.

This adds the digest to the admin domain block serializer, hence adding to the admin domain blocks API

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1666b19) 85.00% compared to head (175aaaa) 85.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29092   +/-   ##
=======================================
  Coverage   85.00%   85.00%           
=======================================
  Files        1058     1058           
  Lines       28281    28283    +2     
  Branches     4538     4538           
=======================================
+ Hits        24040    24042    +2     
  Misses       3078     3078           
  Partials     1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 6, 2024
Merged via the queue into mastodon:main with commit 4fb7f61 Feb 6, 2024
28 checks passed
@ClearlyClaire ClearlyClaire added the to backport PR needed to be backported label Feb 6, 2024
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
ThisIsMissEm added a commit to ThisIsMissEm/mastodon-documentation that referenced this pull request Mar 12, 2024
When creating a domain block, if there is already a domain block rule for the domain, then the existing block is returned. This documents that behavior.

I've also documented the `digest` property which was added in mastodon/mastodon#29092
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
andypiper pushed a commit to mastodon/documentation that referenced this pull request May 7, 2024
* Update admin/domain_blocks to include conflict response

When creating a domain block, if there is already a domain block rule for the domain, then the existing block is returned. This documents that behavior.

I've also documented the `digest` property which was added in mastodon/mastodon#29092

* Document digest in Admin DomainBlock Entity
@ClearlyClaire ClearlyClaire mentioned this pull request May 13, 2024
@ClearlyClaire ClearlyClaire removed the to backport PR needed to be backported label May 17, 2024
This was referenced May 29, 2024
ttrace pushed a commit to ttrace/mastodon that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants