New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable administrative doorkeeper routes #29187
Merged
ClearlyClaire
merged 1 commit into
mastodon:main
from
ThisIsMissEm:feat/disable-oauth-admin-routes
Feb 13, 2024
Merged
Disable administrative doorkeeper routes #29187
ClearlyClaire
merged 1 commit into
mastodon:main
from
ThisIsMissEm:feat/disable-oauth-admin-routes
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These routes allow for the administration of OAuth 2.0 applications on the instance, however, they are not currently integrated into Mastodon, nor protected via the new user roles functionality, but instead by legacy admin flags.
ThisIsMissEm
force-pushed
the
feat/disable-oauth-admin-routes
branch
from
February 13, 2024 15:55
40d7664
to
b9e1dec
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #29187 +/- ##
==========================================
- Coverage 85.01% 85.01% -0.01%
==========================================
Files 1059 1060 +1
Lines 28277 28285 +8
Branches 4538 4537 -1
==========================================
+ Hits 24040 24046 +6
- Misses 3074 3075 +1
- Partials 1163 1164 +1 ☔ View full report in Codecov by Sentry. |
Pretty sure codecov is misleading here, since the files it's saying there's missing coverage in are in files I've not touched? |
ClearlyClaire
approved these changes
Feb 13, 2024
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Feb 13, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 13, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
that referenced
this pull request
Feb 14, 2024
mistydemeo
pushed a commit
to mistydemeo/mastodon
that referenced
this pull request
Feb 14, 2024
mistydemeo
pushed a commit
to mistydemeo/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
ClearlyClaire
pushed a commit
to glitch-soc/mastodon
that referenced
this pull request
Feb 14, 2024
AgathaSorceress
pushed a commit
to AgathaSorceress/mastodon
that referenced
this pull request
Feb 14, 2024
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Feb 14, 2024
kmycode
pushed a commit
to kmycode/mastodon
that referenced
this pull request
Feb 14, 2024
noellabo
pushed a commit
to fedibird/mastodon
that referenced
this pull request
Feb 15, 2024
ttrace
pushed a commit
to ttrace/mastodon
that referenced
this pull request
Feb 15, 2024
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These routes allow for the administration of OAuth 2.0 applications on the instance, however, they are not currently integrated into Mastodon, nor protected via the new user roles functionality, but instead by legacy admin flags.
I'll be the first to admit that the request specs added are not idiomatic necessarily, but they should be only temporary until we have a chance to properly integrate these routes into Mastodon. See #27478
@ClearlyClaire as requested.