Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable administrative doorkeeper routes #29187

Merged

Conversation

ThisIsMissEm
Copy link
Contributor

These routes allow for the administration of OAuth 2.0 applications on the instance, however, they are not currently integrated into Mastodon, nor protected via the new user roles functionality, but instead by legacy admin flags.

I'll be the first to admit that the request specs added are not idiomatic necessarily, but they should be only temporary until we have a chance to properly integrate these routes into Mastodon. See #27478

@ClearlyClaire as requested.

These routes allow for the administration of OAuth 2.0 applications on the instance,
however, they are not currently integrated into Mastodon, nor protected via
the new user roles functionality, but instead by legacy admin flags.
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (86500e3) 85.01% compared to head (b9e1dec) 85.01%.
Report is 61 commits behind head on main.

Files Patch % Lines
app/controllers/api/v1/statuses_controller.rb 87.50% 0 Missing and 1 partial ⚠️
app/controllers/auth/sessions_controller.rb 50.00% 0 Missing and 1 partial ⚠️
app/lib/signature_parser.rb 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29187      +/-   ##
==========================================
- Coverage   85.01%   85.01%   -0.01%     
==========================================
  Files        1059     1060       +1     
  Lines       28277    28285       +8     
  Branches     4538     4537       -1     
==========================================
+ Hits        24040    24046       +6     
- Misses       3074     3075       +1     
- Partials     1163     1164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThisIsMissEm
Copy link
Contributor Author

Pretty sure codecov is misleading here, since the files it's saying there's missing coverage in are in files I've not touched?

@ClearlyClaire ClearlyClaire added the to backport PR needed to be backported label Feb 13, 2024
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 13, 2024
Merged via the queue into mastodon:main with commit 46142cd Feb 13, 2024
31 checks passed
ClearlyClaire pushed a commit to ClearlyClaire/mastodon that referenced this pull request Feb 13, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 13, 2024
mistydemeo pushed a commit to mistydemeo/mastodon that referenced this pull request Feb 14, 2024
mistydemeo pushed a commit to mistydemeo/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
ClearlyClaire pushed a commit to glitch-soc/mastodon that referenced this pull request Feb 14, 2024
AgathaSorceress pushed a commit to AgathaSorceress/mastodon that referenced this pull request Feb 14, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Feb 14, 2024
kmycode pushed a commit to kmycode/mastodon that referenced this pull request Feb 14, 2024
noellabo pushed a commit to fedibird/mastodon that referenced this pull request Feb 15, 2024
ttrace pushed a commit to ttrace/mastodon that referenced this pull request Feb 15, 2024
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to backport PR needed to be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants