Remove global boosts state and convert boosts modal to Typescript
#29774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
force-pushed
the
remove-boosts-state
branch
from
bd67e62
to
0e63eae
Compare
renchap
commented
Mar 27, 2024
renchap
force-pushed
the
remove-boosts-state
branch
from
0e63eae
to
3d3a540
Compare
This was referenced Mar 27, 2024
|
This pull request has merge conflicts that must be resolved before it can be merged. |
The state was only used in the boosts modal, so we can use a local state here
renchap
force-pushed
the
remove-boosts-state
branch
from
3d3a540
to
58fd645
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
ClearlyClaire
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state was only used in the boosts modal, so we can use a local state here.
I introduced a temporary
Statustype, but it still requires manually setting the types of attributes until it is properly typed.