Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jest with test:js in package scripts #29938

Closed

Conversation

mjankowski
Copy link
Contributor

In advance of #24981

Actual commands run stay the same, just changing naming in advance of vite changes.

Copy link
Sponsor Member

@renchap renchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I like this, as at the moment the workflow depends on jest-specific arguments, so it might be better to have those explicit here.

This will not reduce the diff in the Vite PR as those lines will need to be modified anyway

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@mjankowski mjankowski force-pushed the vite-extract-package-json-script branch from 1c6cfd6 to aa2a70b Compare April 17, 2024 12:31
Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

@mjankowski mjankowski force-pushed the vite-extract-package-json-script branch from aa2a70b to a3d4090 Compare April 24, 2024 17:53
@mjankowski mjankowski closed this May 3, 2024
@mjankowski mjankowski deleted the vite-extract-package-json-script branch May 30, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants