Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack compose form warnings and add a sensitive attachment hint to the compose form #29954

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

letydoesstuff
Copy link
Sponsor

@letydoesstuff letydoesstuff commented Apr 15, 2024

This PR addresses both #29952 and #29953.

The compose form warning container is rewritten to order the various warnings in the following order of importance:

  1. Sensitive media hint explaining new compose form functionality
  2. Hashtag warning about reduced hashtag visibility on non-public posts
  3. Publicity-related disclaimers and warnings

These warnings are now non-exclusive, meaning they render in a stack with all applicable warnings appearing. Previous behavior was that publicity-related disclaimers and warnings overwrote the hashtag warning.

Additionally, a sensitive attachment hint has been added to explain the "Add content warning" button's new functionality. This hint only appears if the post is marked with a content warning and the post has an attachment added.

nowarningnomedia hashtagwarningnomedia hashtagandfollowerwarningnomedia hashtagandfollowerwarning hashtagandfollowerwarningmediahint

(Please ignore the 10k character limit in the compose form. That's exclusive to my fork and entirely excluded from this PR.)

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good overall. I'll ask the design team for review around the design changes.

app/javascript/mastodon/locales/en.json Show resolved Hide resolved
letydoesstuff added a commit to letydoesstuff/mastodon that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants