Fix not being able to block a subdomain of an already-blocked domain through the API #30119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
reviewed
Apr 29, 2024
|
I think this looks functionally good to me, I'll let you and Matt sort out code formatting / style issues. |
ClearlyClaire
force-pushed
the
fixes/domain-block-api-subdomain
branch
2 times, most recently
from
c3c719b
to
ea52fb3
Compare
…through the API Fixes #29127
ClearlyClaire
force-pushed
the
fixes/domain-block-api-subdomain
branch
from
ea52fb3
to
bbf9d29
Compare
renchap
approved these changes
May 2, 2024
ClearlyClaire
added a commit
that referenced
this pull request
May 10, 2024
…through the API (#30119)
ClearlyClaire
added a commit
that referenced
this pull request
May 10, 2024
…through the API (#30119)
ClearlyClaire
added a commit
that referenced
this pull request
May 10, 2024
…through the API (#30119)
Draft
ClearlyClaire
added a commit
that referenced
this pull request
May 16, 2024
…through the API (#30119)
ClearlyClaire
added a commit
that referenced
this pull request
May 16, 2024
…domain through the API (#30119)
ClearlyClaire
added a commit
that referenced
this pull request
May 16, 2024
…through the API (#30119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29127
The previous implementation was deliberately kept simple but this outright prevented to create domain blocks for subdomains of already-blocked domains.