Remove deprecated Import model
#30345
Conversation
|
This needs to be merged before we release our next major update, as it will prevent to update from a pre-4.2 version to the version containing this. |
You meant “after we release our next major update”? |
|
No, before we release it? So people can upgrade to the latest 4.x release (and we know they will have done the migration) then upgrade to 5.0 (which will require you to be up-to-date on the latest 4.x before upgrading to the next major) |
|
Ok, I think we do agree, I just was confused by your initial post as it seemed to imply the earlier it was merged, the better. The cost of merging it early is breaking in-progress imports for instances updating from pre-4.2.0 to a release containing this change. The cost of merging it late is carrying “dead” code for longer. I agree that 5.0 sounds like a good breakpoint to get rid of this. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
remove-deprecated-import-class
branch
from
2377350
to
2293efa
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
remove-deprecated-import-class
branch
from
2293efa
to
d9fab6d
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
remove-deprecated-import-class
branch
from
d9fab6d
to
8c2666d
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
remove-deprecated-import-class
branch
from
8c2666d
to
e3bdf0b
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
mjankowski
force-pushed
the
remove-deprecated-import-class
branch
from
e3bdf0b
to
42022e1
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
mjankowski
force-pushed
the
remove-deprecated-import-class
branch
from
42022e1
to
3dc064b
Compare
mjankowski
force-pushed
the
remove-deprecated-import-class
branch
from
3dc064b
to
60babfa
Compare
Attempting to remove the deprecated code from #21054