-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rubocop
binstub, simplify configuration
#30407
Add rubocop
binstub, simplify configuration
#30407
Conversation
3549cfc
to
fb61536
Compare
Added a few more ideas/commits here, updated description to reflect. |
81a97c2
to
44323c3
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
44323c3
to
1feaa11
Compare
This pull request has resolved merge conflicts and is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the benefit of adding a binstup for rubocop?
For the binstub aspect specifically here, motivation is some mix of:
Not earth shattering, just small improvement (we have bin/rails, bin/rspec, bin/rake, etc already) |
1feaa11
to
500c9ff
Compare
Series of related changes:
bin/rubocop
binstub for rubocop and configure CI linter call to use it.rubocop.yml
file to ONLY declare theAllCops
config and allow other files to come in viainherit_from
configNo rules or config are actually changed here, but I do want to continue to work through the _todo file and some of the top-level
Exclude
I've moved here.Many of these ideas are inspired by this approach: https://evilmartians.com/chronicles/rubocoping-with-legacy-bring-your-ruby-code-up-to-standard
I have a WIP branch which does a version of the "start with standardrb ruleset and then override" described in that blog post, but wanted to start with just the config portion.