Fix createDataLoadingThunk and related actions
#30408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
force-pushed
the
fix-dataloader-action
branch
from
a563b04
to
5df3310
Compare
renchap
force-pushed
the
fix-dataloader-action
branch
from
5df3310
to
cc84f3f
Compare
ClearlyClaire
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30270 broke the 3 changed actions (including
reblogandunreblog) because I did not test it, and did not messed up what version I should push in my experiments.This should be working and is the intended interface for the action creator. It is a best practice to have an unique object argument to thunks so the arguments passed to the action are explicit.