Simplify isIntersecting in status_list.js #3371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the same functionality as before, but removes some unnecessary object allocations and adds a comment explaining what's going on.
Essentially the point of the array was to force the component to resolve
shouldComponentUpdate()
to true whenever theisIntersecting
map changed (because a new array was created). But we can do this more directly by just incrementing an integer, and then there's no need for an extra array.