Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3658 - Update RTL styles #3669

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Fix #3658 - Update RTL styles #3669

merged 1 commit into from
Jun 9, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jun 9, 2017

No description provided.

@clworld
Copy link
Contributor

clworld commented Jun 9, 2017

Yeah. It's fixed.
fixed

I found additional bug …
bad_move
(panel move left when clicking '>', panel move right when clicking '<')

@Gargron
Copy link
Member Author

Gargron commented Jun 9, 2017

@clworld I don't know how to fix that. It would require for the settings component to be aware of being in an RTL environment, and to switch order of the buttons based on that...

Copy link
Contributor

@clworld clworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's property fixes issue #3658. I checked.
Looks good to me for now.

@Gargron Gargron merged commit 9b03cf0 into master Jun 9, 2017
@Gargron Gargron deleted the fix-rtl-columns branch June 9, 2017 17:46
koteitan pushed a commit to koteitan/mastodon that referenced this pull request Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants