Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1010 - When spoiler text is set, enforce sensitivity too #4176

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Fix #1010 - When spoiler text is set, enforce sensitivity too #4176

merged 1 commit into from
Jul 12, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jul 12, 2017

There is a thing that can be done in web UI about connecting the visible/hidden state between the "show more" and the media spoiler, but this resolves the crux of the issue.

Resolves #3979

beatrix-bitrot
beatrix-bitrot approved these changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@beatrix-bitrot beatrix-bitrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very well then! code's simple enough

i think the 'thing that can be done' should be done

but it doesn't need to be done in this changeset imo

@Gargron Gargron merged commit e48d3bf into master Jul 12, 2017
@Gargron Gargron deleted the feature-enforce-sensitive branch July 13, 2017 00:03
@ykzts ykzts mentioned this pull request Jul 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrix-bitrot beatrix-bitrot beatrix-bitrot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gargron @beatrix-bitrot