Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rake task for generate VAPID key #4195

Merged
merged 2 commits into from
Jul 14, 2017
Merged

Add Rake task for generate VAPID key #4195

merged 2 commits into from
Jul 14, 2017

Conversation

ykzts
Copy link
Sponsor Member

@ykzts ykzts commented Jul 14, 2017

ref #3243

output

$ ./bin/rake mastodon:webpush:generate_vapid_key
VAPID_PRIVATE_KEY=xxxxxxxxx
VAPID_PUBLIC_KEY=xxxxxxxxx

sorin-davidoi
sorin-davidoi reviewed Jul 14, 2017
View reviewed changes
.env.production.sample
@@ -36,7 +36,7 @@ OTP_SECRET=
# You should only generate this once per instance. If you later decide to change it, all push subscription will
# be invalidated, requiring the users to access the website again to resubscribe.
#
# ruby -e "require 'webpush'; vapid_key = Webpush.generate_key; puts vapid_key.private_key; puts vapid_key.public_key;"
# Generate with `rake mastodon:webpush:generate_vapid_key` task (`docker-compose run --rm web rake mastodon:webpush:generate_vapid_key` if you use docker compose)
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also appears in vapid.rb.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I added with c106f9c.

@Gargron Gargron merged commit 0fa9dd8 into mastodon:master Jul 14, 2017
@ykzts ykzts deleted the gen-vapid-key branch July 14, 2017 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorin-davidoi sorin-davidoi sorin-davidoi left review comments

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ykzts @Gargron @sorin-davidoi