Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline from focused toot #4448

Merged
merged 2 commits into from
Jul 30, 2017
Merged

Remove outline from focused toot #4448

merged 2 commits into from
Jul 30, 2017

Conversation

ykzts
Copy link
Sponsor Member

@ykzts ykzts commented Jul 30, 2017

before after

@sorin-davidoi
Copy link
Contributor

Isn't this bad practice regarding accessibility?

@Gargron
Copy link
Member

Gargron commented Jul 30, 2017

I suggest replacing the outline with a highlighted background (slightly less bright than the DM background, to avoid confusion - and slightly brighter for DMs)

@ykzts
Copy link
Sponsor Member Author

ykzts commented Jul 30, 2017

@sorin-davidoi @Gargron I changed styles.I feel like I have a better style....

focus toot

focus only toot content

@Gargron Gargron merged commit 29abc94 into mastodon:master Jul 30, 2017
@ykzts ykzts deleted the outline-0 branch July 30, 2017 14:28
@beatrix-bitrot
Copy link
Contributor

@ykzts @Gargron i request that this change be reverted before the release of 1.5.0

the reduction in contrast makes the text significantly more difficult to read

@yiskah
Copy link
Contributor

yiskah commented Jul 31, 2017

Sorin is right, you need to have a way to mark that an object has focus. The outline is standard. If you must use something else you must do some bug-testing first to make sure you aren't making things less accessible. I agree with bea that it would be best to just revert to using the outline; that or test the contrast ratios this brings for every possible text, color, etc. that post-objects (including favs in notifs) can appear with

@nightpool
Copy link
Member

additionally, this change makes it very easy to confuse private messages with ones that are focused.

@ykzts ykzts mentioned this pull request Jul 31, 2017
@ykzts
Copy link
Sponsor Member Author

ykzts commented Jul 31, 2017

@beatrix-bitrot @yiskah @nightpool

additionally, this change makes it very easy to confuse private messages with ones that are focused.

I agree. I actually used it and had a sense of incompatibility.

Please check #4474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants