-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outline from focused toot #4448
Conversation
ykzts
commented
Jul 30, 2017
before | after |
---|---|
![]() |
![]() |
Isn't this bad practice regarding accessibility? |
I suggest replacing the outline with a highlighted background (slightly less bright than the DM background, to avoid confusion - and slightly brighter for DMs) |
@sorin-davidoi @Gargron I changed styles.I feel like I have a better style.... focus tootfocus only toot content |
Sorin is right, you need to have a way to mark that an object has focus. The outline is standard. If you must use something else you must do some bug-testing first to make sure you aren't making things less accessible. I agree with bea that it would be best to just revert to using the outline; that or test the contrast ratios this brings for every possible text, color, etc. that post-objects (including favs in notifs) can appear with |
additionally, this change makes it very easy to confuse private messages with ones that are focused. |
@beatrix-bitrot @yiskah @nightpool
I agree. I actually used it and had a sense of incompatibility. Please check #4474 |