Fix button overflow on confirmation modal for mobile #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jul 31, 2017
pfigel
added a commit
to pfigel/mastodon
that referenced
this pull request
Aug 3, 2017
* tag 'v1.5.0': (333 commits) Bump to 1.5.0 Update Dutch (nl) strings (mastodon#4480) Show SMTP_TLS in config sample (mastodon#4477) fix(web_push_notifications): Send message with welcome notifications (mastodon#4471) Change logo URL for Heroku and Scalingo (mastodon#4476) Add libidn11 to Aptfile (mastodon#4475) Re-add outline (mastodon#4474) do not emojify tm, (R) and (C) (mastodon#4472) i18n: update Persian translation (mastodon#4470) Load extra polyfills when isIntersecting is undefined (mastodon#4469) Bump to 1.5.0rc3 Simplify web UI character counter logic (mastodon#4463) Fix button overflow on confirmation modal for mobile (mastodon#4465) Change RuboCop rules to loose (mastodon#4464) i18n: Update Polish translation (mastodon#4467) Disable sensitive button when with content warnings (mastodon#4460) Fix length validator counting things that look like URIs like URLs (mastodon#4462) Make salutation of email localizable (mastodon#4454) Improve accessibility (part 7) (mastodon#4457) Change to sensitive when adding content warning from web UI (mastodon#4456) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that still button (and text) may overflow on some language or some device width (e.g. iPhone 5s). Reducing horizontal padding from 16px to 8px would helps supporting more (not all) combination, but modifying it requires JS change or
!important.However, this change seems reasonable anyway.
For the reference, we have below translations for "Hide entire domain" now. I think supporting all sentence in current layout is hard, so changing layout on mobile or change translation would be solution.