Handle ActivityPub follows correctly #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActivityPub follows are follow-requests. Always require an Accept. If account is not locked, auto-accept.
nightpool
reviewed
Aug 10, 2017
| NotifyService.new.call(target_account, follow) | ||
| follow_request = FollowRequest.create!(account: @account, target_account: target_account) | ||
|
|
||
| if target_account.locked? |
There was a problem hiding this comment.
does activitypub have a concept of a locked account? I'm not sure I follow the flow of this logic.
There was a problem hiding this comment.
No but we do.
If we get a Follow and we are locked, we create a follow request and notify the user about the follow request. If we are not locked, we auto-accept the follow and notify the user about the follow.
nightpool
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActivityPub follows are follow-requests. Always require an Accept.
If account is not locked, auto-accept.