Periodically remove expired PuSH subscribers #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightpool
reviewed
Aug 21, 2017
| @@ -26,6 +26,7 @@ class Subscription < ApplicationRecord | |||
|
|
|||
| scope :confirmed, -> { where(confirmed: true) } | |||
| scope :future_expiration, -> { where(arel_table[:expires_at].gt(Time.now.utc)) } | |||
| scope :expired, -> { where(arel_table[:expires_at].lt(Time.now.utc)) } | |||
There was a problem hiding this comment.
doing it immediately seems maybe bad depending on when people set their renewal times to be? Something like expires_at.lt(Time.now.utc - 7.days) or 14 days is probably Good Enough and allows for a little bit of leniency.
There was a problem hiding this comment.
@nightpool This matters not. Renewing is the same as subscribing from scratch. The secret is fresh, etc. There is virtually no reason why you'd want to keep a particular record beyond its expiration date. Plus the removal worker runs only once a day.
abcang
pushed a commit
to pixiv/mastodon
that referenced
this pull request
Aug 22, 2017
lindwurm
pushed a commit
to akane-blue/mastodon
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.