Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace self-rolled statsd instrumention with localshred/nsa #5118

Merged
merged 1 commit into from Sep 29, 2017
Merged

Replace self-rolled statsd instrumention with localshred/nsa #5118

merged 1 commit into from Sep 29, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Sep 26, 2017 •
edited

Improvements over old solution:

  • controller stats
  • db stats
  • rails cache hit stats
  • sidekiq job processing stats

@Gargron Gargron added the work in progress Not to be merged, currently being worked on label Sep 26, 2017
@Gargron Gargron force-pushed the feature-consolidate-statsd-instrumentation branch from 2fc09e3 to 5228975 Compare September 27, 2017 21:32
@Gargron Gargron removed the work in progress Not to be merged, currently being worked on label Sep 28, 2017
beatrix-bitrot
beatrix-bitrot approved these changes Sep 29, 2017
View reviewed changes
Copy link
Contributor

@beatrix-bitrot beatrix-bitrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm good. i should try statsd 🤔

@Gargron Gargron merged commit 35a8caf into master Sep 29, 2017
@Gargron Gargron deleted the feature-consolidate-statsd-instrumentation branch October 7, 2017 17:03
rutan pushed a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
@Gargron @rutan
Replace self-rolled statsd instrumention with localshred/nsa (mastodo…
9c7a69c 
…n#5118)
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
@Gargron
Replace self-rolled statsd instrumention with localshred/nsa (mastodo…
a3b3530 
…n#5118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrix-bitrot beatrix-bitrot beatrix-bitrot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gargron @beatrix-bitrot