Dynamically calculate card height for embeds instead of padding #5265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The padding trick was hard-coded to a 16:9 ratio, but we can use width and height provided from OEmbed information and width of the card itself to calculate a new height
nolanlawson
reviewed
Oct 8, 2017
| @@ -75,14 +79,25 @@ export default class Card extends React.PureComponent { | |||
| ); | |||
| } | |||
|
|
|||
| setRef = c => { | |||
| if (c) { | |||
| this.setState({ width: c.offsetWidth }); | |||
There was a problem hiding this comment.
So unfortunately offsetWidth triggers layout… but this is only for video embeds right? Basically YouTube and whatnot?
There was a problem hiding this comment.
Yes. YouTube, Vimeo, Soundcloud, Imgur, Twitch Clip, etc
There was a problem hiding this comment.
Mind you, StatusCard is only ever mounted from DetailedStatus!
nolanlawson
approved these changes
Oct 8, 2017
rutan
pushed a commit
to rutan/mastodon
that referenced
this pull request
Oct 11, 2017
…odon#5265) The padding trick was hard-coded to a 16:9 ratio, but we can use width and height provided from OEmbed information and width of the card itself to calculate a new height
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Oct 20, 2017
…odon#5265) The padding trick was hard-coded to a 16:9 ratio, but we can use width and height provided from OEmbed information and width of the card itself to calculate a new height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The padding trick was hard-coded to a 16:9 ratio, but we can use width and height provided from OEmbed information and width of the card itself to calculate a new height
Unfortunately, imgur's embeds seem generally broken in terms of height, I can observe that on birdsite as well