Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an error when ancestors get loaded before the status itself #5312

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Fix an error when ancestors get loaded before the status itself #5312

merged 1 commit into from
Oct 11, 2017

Commits on Oct 11, 2017

  1. Fix an error when ancestors get loaded before the status itself 

    When ancestors get loaded, we scroll to the target status (i.e. skip
ancestors). However, ancestors may get loaded before the status itself,
then it causes TypeError because `this.node` is undefined yet.

Since we don't show anything until the status gets loaded, we don't need
to scroll to the target status in this time. If we get the status itslef
later, it causes `componentDidUpdate` and scrolling correctly.
    @unarist
    unarist committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    eca1bc4 View commit details
    Browse the repository at this point in the history