Fix #5351 - Redirection with page params after copy emoji #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested if this works? Because I don't think the copy method receives a |
|
@Gargron you're right. 😅 Embarrassingly, I miss it when I commit. |
Gargron
approved these changes
Oct 14, 2017
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Oct 20, 2017
…stodon#5387) * Fix mastodon#5351 - Redirection with page params after copy emoji * Add page params to copy emoji link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As reported in #5351, on admin panel, when copy an emoji (non-local emoji) in the Custom Emoji section and it's on page > 1, it always redirect back to page 1 regardless of whether it's successful/fail. This change fixes that.
Why
It's an inconvenience when trying to copy multiple emojis located on page > 1.
Other possible issues
The same inconvenience happens on the other actions on
CustomEmojisController, such as#copy,#enable&#disable