Update model annotations to use BIGINT for IDs #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhunsaker
force-pushed
the
bugfix/bigint-in-activemodels
branch
5 times, most recently
from
02cf422
to
be2915b
Compare
danhunsaker
force-pushed
the
bugfix/bigint-in-activemodels
branch
2 times, most recently
from
df91a8f
to
8b1a2fc
Compare
danhunsaker
force-pushed
the
bugfix/bigint-in-activemodels
branch
5 times, most recently
from
71325e4
to
8b69df8
Compare
|
Just a quick bump to get some feedback, at least. |
All the migrations have been updated to use BIGINTs for ID fields in the DB, but ActiveRecord needs to be told to treat those values as BIGINT as well. This PR does that.
danhunsaker
force-pushed
the
bugfix/bigint-in-activemodels
branch
from
8b69df8
to
8407946
Compare
Gargron
approved these changes
Nov 12, 2017
|
Unfortunately, since this is auto-generated, this will all get overwritten the next time we run db:migrate |
|
That shouldn't be an issue, since the autogenerated annotations should then correctly be |
|
@danhunsaker Well, for whatever reason, the annotate gem picks them up as integer and not bigint. Otherwise this PR wouldn't have had anything to correct either. |
|
I was a little confused about why the annotations hadn't been updated already in that case. So we're looking at a bug in the annotations gem, then? |
|
It is fixed by ctran/annotate_models#515 . But it has not been released yet. |
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Dec 6, 2017
All the migrations have been updated to use BIGINTs for ID fields in the DB, but ActiveRecord needs to be told to treat those values as BIGINT as well. This PR does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the migrations have been updated to use BIGINTs for ID fields in the DB, but ActiveRecord needs to be told to treat those values as BIGINT as well. This PR does that.