Remove translateZ(0) on modal overlay #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have been added in cca41ea and AFAICT it is not needed. I deployed this fix to malfunctioning.technology and tested opening a modal gallery and swiping left and right in both mobile Firefox and mobile Chrome on a Nexus 5, and didn't observe any performance degradation compared to master.
In principle, usages of
translateZ(0)are very suspect because they force the browser to create a GPU layer. It's almost always better to usewill-changeas documented here.Also, the overlay element that we animate now is
.modal-root, not.modal-root__overlay, and.modal-rootalready haswill-change: opacityapplied to it.